Widen one-shot drift correction media live window to 2x max delay#871
Merged
Widen one-shot drift correction media live window to 2x max delay#871
Conversation
Relax the upper bound of the one-shot drift correction sanity check from deadline + maxMediaRunningTimeDelay to deadline + 2*maxMediaRunningTimeDelay. This prevents rejecting corrections where the adjusted PTS is only slightly ahead of the media time due to jitter.
paulwe
approved these changes
Apr 1, 2026
boks1971
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the upper bound of the one-shot drift correction sanity check from deadline + maxMediaRunningTimeDelay to deadline + 2*maxMediaRunningTimeDelay. This prevents rejecting corrections where the adjusted PTS is only slightly ahead of the media time due to jitter.